Simplify expectations to a single expectation - #254
Merged
Conversation
This is the same as elm-explorations#244, except I didn’t change the public API. We go with a single expectation internally for as long as we can, and only turn that into a singleton list when we hit the public API boundary.
lydell
force-pushed
the
simplify-expectations
branch
from
July 22, 2026 18:07
b7eb06c to
c09f68b
Compare
Janiczek
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #244, except I didn’t change the public API. We go with a single expectation internally for as long as we can, and only turn that into a singleton list when we hit the public API boundary.